Re: [v3 3/3] serial: 8250_dw: Add UPF_SKIP_TEST to flags depend on device tree
From: Vineet Gupta
Date: Thu Aug 13 2015 - 10:20:24 EST
Hi Peter, Greg
On Wednesday 12 August 2015 09:21 PM, Noam Camus wrote:
>> From: Peter Hurley [mailto:peter@xxxxxxxxxxxxxxxxxx]
>> Sent: Wednesday, August 12, 2015 4:17 PM
>> I think Greg's question about the simulator still applies: why upstream this?
>> The simulator is not even identified so how is someone supposed to know this workaround applies?
>> The fact there are no in-tree DT users of this workaround argues against its acceptance.
> I am using UART peripheral for Synopsys simulator same as one used by arch/arc/plat-sim
The osci virtual platform uses nSIM with SystemC based peripheral models. The
issue is in that model and not in nsim per-se.
> I know this platform do not use CONFIG_SERIAL_8250_DW due to some problem I suspect it is relate to the loop test.
Indeed. If you look at git log of osci platform, there was a commit which switched
DT from dw uart driver to stock 8250. Unfortunately the changelog doesn't describe
in detail what the root cause was.
2013-05-16 6eda477b3c54 ARC: [nsimosci] Change .dts to use generic 8250 UART
> Maybe Vineet Gupta or Alexey Brodkin from Synopsys which are CC here can comment.
> So It just happen for me to be a pioneer with this.
> More than that "no-loopback-test" is an option already exist for core 8250, and since DW is only an extension for this driver it should also benefit from this option.
It seems Noam has made some changes to model today and we might need this patch
after all. Noam ?
> If all this is yet not enough, should I re-send this "patch set" again without this specific patch?
> Noam Camus
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/