Re: [PATCH v3] ARM: tegra: cpuidle: implement cpuidle_state.enter_freeze()

From: Thierry Reding
Date: Thu Aug 13 2015 - 10:55:48 EST


On Tue, May 19, 2015 at 04:49:12PM +0200, Tomeu Vizoso wrote:
> This callback is expected to do the same as enter() but it has to
> guarantee that interrupts aren't enabled at any point in its execution,
> as the tick is frozen.
>
> It will be called when the system goes to suspend-to-idle and will
> reduce power usage because CPUs won't be awaken for unnecessary IRQs.
>
> By setting the CPUIDLE_FLAG_TIMER_STOP flag, we can reuse the same code
> for both the enter() and enter_freeze() callbacks.
>
> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@xxxxxxxxxxxxx>
> Cc: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
>
> ---
>
> v3: * Set CPUIDLE_FLAG_TIMER_STOP to simplify things as suggested by
> Lorenzo Pieralisi
> v2: * Disable FIQs also when suspending-to-idle
> ---
> arch/arm/mach-tegra/cpuidle-tegra114.c | 13 +++++++++----
> 1 file changed, 9 insertions(+), 4 deletions(-)

Applied, thanks.

Thierry

Attachment: signature.asc
Description: PGP signature