Re: [PATCH] usb: phy: phy-generic: Fix reset behaviour on legacy boot

From: Fabio Estevam
Date: Thu Aug 13 2015 - 21:48:16 EST


On Thu, Aug 13, 2015 at 7:28 AM, Roger Quadros <rogerq@xxxxxx> wrote:
> The gpio-desc migration done in v4.0 caused a regression
> with legacy boots due to reversed reset logic.
> e.g. omap3-beagle USB host breaks on legacy boot.
>
> Request the reset GPIO with GPIOF_ACTIVE_LOW flag so that
> it matches the driver logic and pin behaviour.
>
> Fixes: e9f2cefb0cdc ("usb: phy: generic: migrate to gpio_desc")
> Cc: <stable@xxxxxxxxxxxxxxx> # 4.0+
> Signed-off-by: Roger Quadros <rogerq@xxxxxx>

The USB on my mx51-babbage board still works fine with this change:

Tested-by: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/