Re: [PATCH 1/2] staging: lustre: fix static declarations in libcfs

From: Greg Kroah-Hartman
Date: Fri Aug 14 2015 - 21:50:22 EST


On Fri, Aug 14, 2015 at 04:00:31PM +0200, Maxime Lorrillere wrote:
> On vendredi 14 août 2015 à 11:28:35 (+0530), Sudip Mukherjee wrote
> > On Wed, Aug 12, 2015 at 11:51:04AM +0200, Maxime Lorrillere wrote:
> > > This patch fix the following sparse warnings in libcfs/linux/linux-debug.c:
> > > >>> linux-debug.c:64:6: warning: symbol 'lnet_upcall' was not declared. Should it be static?
> > > >>> linux-debug.c:65:6: warning: symbol 'lnet_debug_log_upcall' was not declared. Should it be static?
> > >
> > > Signed-off-by: Maxime Lorrillere <maxime.lorrillere@xxxxxxxxx>
> > > ---
> > You have not build tested.
> >
> > WARNING: "lnet_debug_log_upcall" [drivers/staging/lustre/lustre/libcfs/libcfs.ko] undefined!
> > WARNING: "lnet_upcall" [drivers/staging/lustre/lustre/libcfs/libcfs.ko] undefined!
>
> Sorry, I've only rebuild lustre separately.
>
> Patch 2/2 builds fine, should I submit it separately ?

Yes please.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/