Re: [PATCH] staging: lustre: ptlrpc: add missing include directive

From: Ioan-Adrian Ratiu
Date: Sat Aug 15 2015 - 04:14:01 EST


On Fri, 14 Aug 2015 18:50:24 -0700
Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:

> On Fri, Aug 14, 2015 at 12:57:06PM +0300, Ioan-Adrian Ratiu wrote:
> > Without including ptlrpc_internal.h, GCC gives prototype warnings
> > "pack_generic.c:642:5: warning: no previous prototype for ..."
>
> It does? What version of gcc give you that, I don't see that here.
>

Yes, but it's a non-default warning (-Wmissing-prototypes)

$ gcc --version
gcc (Gentoo 4.9.3 p1.0, pie-0.6.2) 4.9.3

When testing the above patch I've used Ubuntu Vivid Vervet's gcc
(also 4.9 I think, I don't have access to that machine right now).

To see the warn I'm adding "ccflags-y := -Wmissing-prototypes"
to a Makefile then "make SUBDIRS=..."
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/