Re: [PATCH v2 7/7] pmem, dax: have direct_access use __pmem annotation

From: Christoph Hellwig
Date: Sat Aug 15 2015 - 05:20:02 EST

On Thu, Aug 13, 2015 at 10:51:11AM -0600, Ross Zwisler wrote:
> Update the annotation for the kaddr pointer returned by direct_access()
> so that it is a __pmem pointer. This is consistent with the PMEM driver
> and with how this direct_access() pointer is used in the DAX code.

IFF we stick to the __pmem annotations this looks good.

That beeing said I start to really dislike them. We don't special
accesors to read/write from pmem, we just need to explicitly commit
it if we want to make it persistent. So I really don't see the need
to treat it special and require all the force casts to and from the
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at