Re: [PATCH v2] drivers/hid: Check result of debugfs_create_dir() and debugfs_create_file()

From: Alexander Kuleshov
Date: Thu Aug 20 2015 - 13:39:23 EST


Hello Jiri,

On 08-19-15, Jiri Kosina wrote:
> On Wed, 19 Aug 2015, Alexander Kuleshov wrote:
>
> >
> > - hid_debug_init();
> > + if (hid_debug)
> > + hid_debug_init();
>
> How is this change related to the rest of the patch?
>
> It's wrong anyway, because hid_debug is independent of the debugfs HID
> debugging facility. Please see for example the printk() a few lines above
> in this very function, which is emited in case hid_debug is enabled.
>

hmm, I thought that these things are related. I've remove all hid_debug check
and sent v3 of the patch.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/