Re: [PATCH block/for-linus] writeback: fix syncing of I_DIRTY_TIME inodes

From: Eryu Guan
Date: Sun Aug 23 2015 - 23:18:48 EST


On Mon, Aug 24, 2015 at 11:11:23AM +1000, Dave Chinner wrote:
>
> Eryu, can you change the way you run the event trace to be:
>
> $ sudo trace-cmd <options> -o <outfile location> ./check <test options>
>
> rather than running the trace as a background operation elsewhere?
> Maybe that will give better results.

The results are here

http://128.199.137.77/writeback-v3/

>
> Also, it would be informative to us if you can reproduce this with a
> v5 filesystem (i.e. mkfs.xfs -m crc=1) because it has much better
> on-disk information for sequence-of-event triage like this. If you
> can reproduce it with a v5 filesystem, can you post the trace and
> metadump?

This seems to be harder to reproduce with tracepoints enabled, but I'll
keep trying, and the tests below.

Thanks,
Eryu

>
> Other things to check (separately):
>
> - change godown to godown -f
> - add a "sleep 5" before running godown after sync
> - add a "sleep 5; sync" before running godown
>
> i.e. I'm wondering if sync is not waiting for everything, and so we
> aren't capturing the IO completions because the filesystem is
> already shut down by the time they are delivered...
>
> Cheers,
>
> Dave.
> --
> Dave Chinner
> david@xxxxxxxxxxxxx
>
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/