Re: [PATCH 2/3] mm, compaction: export tracepoints zone names to userspace

From: Steven Rostedt
Date: Mon Aug 31 2015 - 11:33:06 EST


On Thu, 27 Aug 2015 17:24:03 +0200
Vlastimil Babka <vbabka@xxxxxxx> wrote:

> Some compaction tracepoints use zone->name to print which zone is being
> compacted. This works for in-kernel printing, but not userspace trace printing
> of raw captured trace such as via trace-cmd report.
>
> This patch uses zone_idx() instead of zone->name as the raw value, and when
> printing, converts the zone_type to string using the appropriate EM() macros
> and some ugly tricks to overcome the problem that half the values depend on
> CONFIG_ options and one does not simply use #ifdef inside of #define.
>
> trace-cmd output before:
> transhuge-stres-4235 [000] 453.149280: mm_compaction_finished: node=0
> zone=ffffffff81815d7a order=9 ret=partial
>
> after:
> transhuge-stres-4235 [000] 453.149280: mm_compaction_finished: node=0
> zone=Normal order=9 ret=partial
>
> Signed-off-by: Vlastimil Babka <vbabka@xxxxxxx>
> Cc: Joonsoo Kim <iamjoonsoo.kim@xxxxxxx>
> Cc: Steven Rostedt <rostedt@xxxxxxxxxxx>

Reviewed-by: Steven Rostedt <rostedt@xxxxxxxxxxx>

-- Steve

> Cc: Ingo Molnar <mingo@xxxxxxxxxx>
> Cc: Mel Gorman <mgorman@xxxxxxx>
> Cc: David Rientjes <rientjes@xxxxxxxxxx>
> ---
> include/trace/events/compaction.h | 38 ++++++++++++++++++++++++++++++++------
> 1 file changed, 32 insertions(+), 6 deletions(-)
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/