Re: [PATCH] arch/x86/mm/srat: Print non-volatile flag in SRAT

From: Thomas Gleixner
Date: Tue Sep 01 2015 - 15:26:43 EST


On Tue, 1 Sep 2015, Linda Knippers wrote:
> On 9/1/2015 3:17 PM, Thomas Gleixner wrote:
> > On Tue, 1 Sep 2015, Linda Knippers wrote:
> >> Nobody checks this flag but it would be interesting to know if it's being
> >> set on any platforms.
> >
> > What you're omitting to explain, is WHY it would be interesting.
>
> With the addition of NVDIMM support, a question came up as to whether
> NVDIMM ranges should be in the SRAT with this bit set. I think the
> consensus was no because the ranges are in the NFIT with proximity
> domain information there.
>
> ACPI is not clear on the meaning of this bit in the SRAT.
> If someone is setting it, we might want to ask them what they expect
> to happen with it.
>
> Right now this bit is only printed if all the ACPI debug information is
> turned on.
>
> Sorry, I should have explained more.

Indeed. And that explanation wants to be in the changelog. Care to resend?

Thanks,

tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/