Re: [PATCH] x86/headers: Fix (old) header file dependency bug in uapi/asm/sigcontext32.h

From: Ingo Molnar
Date: Sat Sep 05 2015 - 03:32:53 EST



* Mikko Rapeli <mikko.rapeli@xxxxxx> wrote:

> > sigcontext32.h is a 64-bit only header (for compat functionality), and you are
> > trying to build this on i386, right?
>
> Yes, i386 32bit.
>
> > In theory we could unify them mostly, the two structures match mostly, except that
> > '_fpstate_ia32::padding' is named 'padding1' in _fpstate, and there's also some
> > legacy uglies wrt. user-space sigcontext definitions.
> >
> > So this either gets cleaned up properly, with the legacy hacks/wrappers clearly
> > isolated, or we could state that you shouldn't build 64-bit headers in 32-bit
> > environments.
>
> Should the sigcontext32.h have some 32bit ifdefs maybe?

That gets ugly pretty fast.

> I assume that the exported header files should be the same for both 64 and 32
> bit i386/x86

Yes. I have written a small series cleaning up all these header problems - I'll
send it out in a few minutes.

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/