Re: [PATCH] infiniband:mlx4:Fix assumation that ib_get_cached_pkey runs successfully in build_mlx_header

From: Or Gerlitz
Date: Thu Sep 10 2015 - 02:22:14 EST


On 9/10/2015 2:04 AM, Nicholas Krause wrote:
This fixes a incorrect assumation that ib_get_cached_pkey always runs
successfully in the function build_mlx_header by checking if the calls
to this particular function return the error code, -EINVAL in order to
signal they failed to grap the public key for the device structure pointer
passed to this function and if so return immediately to the caller of
mlx_header with the error code -EINVAL to signal a error has occurred
when calling this particular function that the caller must handle in
its own intended error paths.

I am totally breathless, put 2-3 periods somewhere along this crazingly long sentence.

Does this fixes some specific commit? if yes, please add Fixes: tag @ before your S.O.B linewith the offending commit short ID (--abbrev=12)

run speller (e.g assumation --> assumption), use IB/mlx4: prefix, add space between the ":" to the 1st word of the title, e.g:

IB/mlx4: Fix assumption that ib_get_cached_pkey runs successfully in build_mlx_header

Or.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/