Re: [Linux v4.2] workqueue: llvmlinux: acpid: BUG: sleeping function called from invalid context at kernel/workqueue.c:2680

From: Tejun Heo
Date: Thu Sep 10 2015 - 10:54:05 EST


On Thu, Sep 10, 2015 at 10:52:27AM -0400, Tejun Heo wrote:
> Hey,
>
> On Thu, Sep 10, 2015 at 09:04:27AM +0800, Lai Jiangshan wrote:
> > I think we need to add might_sleep() on the top of __cancel_work_timer().
> > The might_sleep() on the start_flush_work() doesn't cover all the
> > paths of __cancel_work_timer().
> > And it can help to narrow the area of this bug.
>
> Sure, can you submit a patch?

That said, this one is likely not a bug in the kernel code but more
likely llvm either miscompiling or deviating from gcc behavior on some
corner cases.

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/