Re: [PATCH 4/6] Staging: iio: cdc: Prefer using the BIT macro

From: Greg Kroah-Hartman
Date: Sat Sep 12 2015 - 11:49:24 EST


On Sat, Sep 12, 2015 at 04:47:23PM +0530, Shraddha Barke wrote:
>
>
> On Sat, Sep 12, 2015 at 3:17 PM, Jonathan Cameron <jic23@xxxxxxxxxx> wrote:
>
> On 10/09/15 17:32, Shraddha Barke wrote:
> > This patch replaces bit shifting on 1 with the BIT(x) macro
> >
> > This was done with coccinelle:
> > @@ int g; @@
> >
> > -(1 << g)
> > +BIT(g)
> >
> > Signed-off-by: Shraddha Barke <shraddha.6596@xxxxxxxxx>
> Something odd happened here as this is only a small proportion of the cases
> that should be updated in this file.  There's one at the bottom of the
> patch for starters!
>
>
> I didn't apply BIT(x) for mixed cases.I think I should drop this patch
> altogether but
> Greg has added it. Will it cause problems ? :(

Greg can always drop it :)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/