Re: [PATCH v4 2/3] Staging: vt6656: Bool tests don't need comparisons

From: Julia Lawall
Date: Sun Sep 13 2015 - 12:18:34 EST




On Sun, 13 Sep 2015, Shraddha Barke wrote:

> This patch removes comparisons to true/false values on bool variables.
>
> Change in v4-
> No changes

This needs to go under the ---. It is not information that needs to be
preserved in the git log.

julia

> Signed-off-by: Shraddha Barke <shraddha.6596@xxxxxxxxx>
> ---
> drivers/staging/vt6656/wcmd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/vt6656/wcmd.c b/drivers/staging/vt6656/wcmd.c
> index 3cbf479..c8e69ff 100644
> --- a/drivers/staging/vt6656/wcmd.c
> +++ b/drivers/staging/vt6656/wcmd.c
> @@ -177,7 +177,7 @@ int vnt_schedule_command(struct vnt_private *priv, enum vnt_cmd command)
> ADD_ONE_WITH_WRAP_AROUND(priv->cmd_enqueue_idx, CMD_Q_SIZE);
> priv->free_cmd_queue--;
>
> - if (priv->cmd_running == false)
> + if (!priv->cmd_running)
> vnt_cmd_complete(priv);
>
> return true;
> --
> 2.1.4
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/