Re: [PATCH 2/4] ARM: sun8i: Add the A33 AHB1 gates clock driver

From: Maxime Ripard
Date: Mon Sep 14 2015 - 10:40:49 EST


Hi Peter,

On Sun, Sep 13, 2015 at 05:13:12PM +0200, Peter Korsgaard wrote:
> >>>>> "Maxime" == Maxime Ripard <maxime.ripard@xxxxxxxxxxxxxxxxxx> writes:
>
> > The A33 has different a different gates array than the A23, add the node to
> > the DT.
>
> NIT: 2x different.

Ah, good catch, thanks!

> Shouldn't the a23 one then move from sun8i-a23-a33.dtsi to
> sun8i-a23.dtsi?

It is, but in order to preserve bisectability, I declared the A33 node
first, that has precedence over the A23 still in the common DTSI, and
removed the A23 in the next patch.

Maxime

--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Attachment: signature.asc
Description: Digital signature