Re: [PATCH] xen: fix the check of e_pfn in xen_find_pfn_range

From: Zhenzhong Duan
Date: Mon Sep 14 2015 - 22:02:12 EST


Hi David

Konrad just ping me on this patch. I originally think I missed to cc you but I does.
Could you ack or nak it?

thanks
zduan

å 2015/9/2 19:04, Juergen Gross åé:
On 09/02/2015 12:51 PM, Zhenzhong Duan wrote:
On some numa system, after dom0 up, we see below warning even if there are
enough pfn ranges could be used for remapping.
"Unable to find available pfn range, not remapping identity pages"

Fix it to avoid getting a memory region of zero size in xen_find_pfn_range.

Signed-off-by: Zhenzhong Duan <zhenzhong.duan@xxxxxxxxxx>

Reviewed-by: Juergen Gross <jgross@xxxxxxxx>

---
arch/x86/xen/setup.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/xen/setup.c b/arch/x86/xen/setup.c
index a3a7546..c11f6b2 100644
--- a/arch/x86/xen/setup.c
+++ b/arch/x86/xen/setup.c
@@ -178,7 +178,7 @@ static unsigned long __init xen_find_pfn_range(
e_pfn = PFN_DOWN(entry->addr + entry->size);

/* We only care about E820 after this */
- if (e_pfn < *min_pfn)
+ if (e_pfn <= *min_pfn)
continue;

s_pfn = PFN_UP(entry->addr);


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/