Re: possible new false positive in checkpatch

From: Andy Whitcroft
Date: Tue Sep 15 2015 - 11:01:32 EST


On Tue, Sep 15, 2015 at 05:50:40PM +0300, Tal Shorer wrote:

> > Yes it feels like that should be eliding them completely, and likely any
> > following space as well, something like this:
> >
> > $s =~ s/$;+\s*//g;
> > $c =~ s/$;+\s*//g;
> >
> Replacing the problematic lines with these fixes the issue.
> > > Introduced in commit 9f5af480f4554aac12e002b6f5c2b04895857700:
> > > checkpatch: improve SUSPECT_CODE_INDENT test
> > > Commenting out these lines removes the warning.
> > >
> > > This pattern exists in many places around the kernel source.
> > > Is this the intended behavior?
> >
> > Seems wrong to me.
> >
> > -apw
>
> Which git tree is checkpatch developed in? Linus's?

Yeah in Linus' tree.

-apw
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/