Re: [PATCH 02/26] clk: Replace __clk_get_num_parents with clk_hw_get_num_parents()

From: Scott Wood
Date: Thu Sep 17 2015 - 20:18:48 EST


On Fri, 2015-07-31 at 10:03 -0700, Stephen Boyd wrote:
> Mostly converted with the following semantic patch:
>
> @@
> struct clk_hw *E;
> @@
>
> -__clk_get_num_parents(E->clk)
> +clk_hw_get_num_parents(E)

I don't understand why this is considered a clock provider API. How is a
clock consumer, such as cpufreq, supposed to find out the number of parents
or similar information, so that it knows what its options are for calling
clk_set_parent()?

This is the caller I had in mind:
http://patchwork.ozlabs.org/patch/507619/

Surely asking the clock to describe itself is better than what that cpufreq
driver currently does, which is to look in the device tree and make
assumptions about how that maps to what the clock provider driver does...

-Scott

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/