Re: [PATCH v2 8/9] [media] handle 64-bit time_t in v4l2_buffer

[Arnd Bergmann]

On Friday 18 September 2015 11:49:50 Hans Verkuil wrote:
> *If* the conversion takes place only in v4l2-ioctl.c, then it makes sense
> have these structs + ioctls moved to v4l2-ioctl.h.

Ok.
 
> I noticed that v4l2-compat-ioctl32.c wasn't changed. Is that right? I have
> unfortunately no time to double-check that, but it surprised me.

Yes, I pointed that out in the cover letter as something that is still
left to be done. If we end up taking the current approach (plus the
change to the location of the conversion), the compat code would
basically be duplicated.

Alternatively, the video_usercopy() function could just be changed
to handle both 32-bit formats directly (including conversion of the
multiplane array) and then we can remove that compat handler for
all eight ioctls.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/