spi-imx: wait_for_completion should timeout even in non-DMA transfer cases

From: Jean-Michel Hautbois
Date: Fri Sep 18 2015 - 08:38:54 EST


Hi,

I am wondering why in spi-imx the spi_imx_pio_transfer() function is
calling wait_for_completion() and not wait_for_completion_timeout() as
in the spi_imx_dma_transfer() one.
I can't see a good reason for this, maybe should it be calculated
based on the spi clock and transfer->len, or at least be the same as
IMX_DMA_TIMEOUT which is 3 seconds ?
If you want it, I have a patch, just tell me if you are interested and
if you prefer a calculated timeout or even something else ?

Thanks,
JM
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/