Re: [PATCH 2/3] usb: gadget: at91_udc: mention proper dependency

[Sudip Mukherjee]

On Sun, Sep 20, 2015 at 11:15:28AM -0500, Felipe Balbi wrote:
> On Sat, Sep 19, 2015 at 10:42:58PM +0530, Sudip Mukherjee wrote:
> > While building allmodconfig on avr32 the build failed with the error:
> > "at91_pmc_base" [drivers/usb/gadget/udc/atmel_usba_udc.ko] undefined!
> > 
> > On checking the code it turned out that if CONFIG_OF is defined then it
> > is using at91_pmc_read() which is using at91_pmc_base. And unless
> > COMMON_CLK_AT91 is defined we donot have at91_pmc_base. And
> > COMMON_CLK_AT91 is available with AT91 architecture.
> > Mention the dependency such that this driver builds with avr32 only if
> > OF is not enabled.
> > 
> > Signed-off-by: Sudip Mukherjee <sudip@xxxxxxxxxxxxxxx>
> > ---
> > 
> > Tested build with at91_dt_defconfig and allmodconfig of avr32. Build log
> > at:
> > https://travis-ci.org/sudipm-mukherjee/parport/builds/81168845
> > 
> >  drivers/usb/gadget/udc/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/usb/gadget/udc/Kconfig b/drivers/usb/gadget/udc/Kconfig
> > index 9a3a6b0..cdbff54 100644
> > --- a/drivers/usb/gadget/udc/Kconfig
> > +++ b/drivers/usb/gadget/udc/Kconfig
> > @@ -55,7 +55,7 @@ config USB_LPC32XX
> >  
> >  config USB_ATMEL_USBA
> >  	tristate "Atmel USBA"
> > -	depends on AVR32 || ARCH_AT91
> > +	depends on ((AVR32 && !OF) || ARCH_AT91)
> 
> any chance you can add || COMPILE_TEST here ? I'd like to make
> sure this builds on my end too.
With "depends on ((AVR32 && !OF) || ARCH_AT91 || COMPILE_TEST)"
normal allmodconfig builiding for x86_64 failed with:

drivers/usb/gadget/udc/atmel_usba_udc.c: In function âusba_startâ:
drivers/usb/gadget/udc/atmel_usba_udc.c:1783:25: error: âUSBA_ENABLE_MASKâ undeclared (first use in this function)
  usba_writel(udc, CTRL, USBA_ENABLE_MASK);
                         ^
drivers/usb/gadget/udc/atmel_usba_udc.c: In function âusba_stopâ:
drivers/usb/gadget/udc/atmel_usba_udc.c:1800:25: error: âUSBA_DISABLE_MASKâ undeclared (first use in this function)
  usba_writel(udc, CTRL, USBA_DISABLE_MASK);
                         ^

Looks like USBA_DISABLE_MASK and USBA_ENABLE_MASK is defined under
#if defined(CONFIG_AVR32). :(

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/