Re: [PATCH] kselftest: using built-in rule when delete file
From: Darren Hart
Date: Fri Sep 25 2015 - 11:44:56 EST
On Thu, Sep 24, 2015 at 12:07:47PM +1000, Michael Ellerman wrote:
> On Thu, 2015-09-24 at 10:05 +0800, long.wanglong wrote:
> > On 2015/9/24 9:46, Michael Ellerman wrote:
> > > On Wed, 2015-09-23 at 09:40 +0000, Wang Long wrote:
> > >> Use make's built-in rules to when delete a file
> > >> or delete files.
> > >
> > > It's not a built-in rule, it's a variable.
> > SorryïI did not describe clearly. It is a variable used as
> > name of program in built-in rules.
> > > Personally I think using rm directly is clearer, but I guess this is fine. Do
> > > you actually want to override $RM ?
> > So far, I do not want to override $(RM). But I found that some test's Makefile
> > using *$(RM)* while the other's using *rm -f*, I think it is better to use one
> > of them in all unit tests.
Agreed, consistency is good.
> > Do you think which one is better?
> I prefer just using rm -f, because it's less magic, everyone knows what it does.
Also agreed, it's explicit and perfectly functional.
Intel Open Source Technology Center
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/