Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock'
From: Viresh Kumar
Date: Sat Sep 26 2015 - 14:45:40 EST
On 25 September 2015 at 15:19, Rafael J. Wysocki <rafael@xxxxxxxxxx> wrote:
> So if you allow something like debugfs to update your structure, how
> do you make sure there is the proper locking?
Not really sure at all.. Isn't there some debugfs locking that will
jump in, to avoid updation of fields to the same device?
> Is that not a problem in all of the places modified by the [2/2]?
Right, but its not new AFAICT.
We already have u32 fields in those structs and on 64 bit machines
we have the same read-update-write problems for two consecutive
> How can the future users of the API know what to do to avoid potential
> problems with it?
No idea really :)
>> Anyway, that problem isn't here for sure as its between two
>> unsigned-longs. So, should I just move it to bool and resend ?
> I guess it might be more convenient to fold this into the other patch,
> because we seem to be splitting hairs here.
I can and that's what I did. But then Arnd asked me to separate it
out. I can fold it back if that's what you want.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/