RE: [PATCH 12/12] mtd: nand-bbt: move nand_bbt.c to mtd folder
From: Peter Pan ææ (peterpandong)
Date: Mon Sep 28 2015 - 04:39:13 EST
Thanks for your reply.
On Fri, Sep 25, 2015 at 06:48:05AM +0000, Brian Norris < computersforpeace@xxxxxxxxx >
> Hi Peter,
> First of all, thanks for taking the time to try to address my
> long-delayed comments. I hope to give this a proper look soon. (I also
> hope you can fix the email threading soon! I know that's a pain...)
Sorry for bringing inconvenience . I'm working on this now. I'm trying to enable
git-send-email on my server. Once it done, I will resend this series. But please look
at this series first if you have time.
> But first, a simpler comment:
> On Fri, Sep 25, 2015 at 06:48:05AM +0000, Peter Pan ææ (peterpandong)
> > Since struct nand_chip is removed from nand_bbt.c, BBT is now
> > shareable. Both NAND and SPI NAND can use it. So move nand_bbt.c
> > from nand/ foler to mtd/ folder and create MTD_NAND_BBT config.
> > Both NAND and SPI NAND should depend on MTD_NAND_BBT.
> > Signed-off-by: Peter Pan <peterpandong@xxxxxxxxxx>
> > ---
> > drivers/mtd/Kconfig | 7 +
> > drivers/mtd/Makefile | 1 +
> > drivers/mtd/nand/Kconfig | 2 +-
> > drivers/mtd/nand/Makefile | 2 +-
> > drivers/mtd/nand/nand_bbt.c | 1289 -------------------------------------------
> > drivers/mtd/nand_bbt.c | 1289
> > 6 files changed, 1299 insertions(+), 1291 deletions(-)
> > delete mode 100644 drivers/mtd/nand/nand_bbt.c
> > create mode 100644 drivers/mtd/nand_bbt.c
> > diff --git a/drivers/mtd/nand/nand_bbt.c b/drivers/mtd/nand/nand_bbt.c
> > deleted file mode 100644
> > index 47c1084..0000000
> > --- a/drivers/mtd/nand/nand_bbt.c
> > +++ /dev/null
> > @@ -1,1289 +0,0 @@
> [snip deleting entire file]
> > diff --git a/drivers/mtd/nand_bbt.c b/drivers/mtd/nand_bbt.c
> > new file mode 100644
> > index 0000000..47c1084
> > --- /dev/null
> > +++ b/drivers/mtd/nand_bbt.c
> > @@ -0,0 +1,1289 @@
> [snip adding the whole file again -- exactly the same I hope?]
Yes. The whole file is exactly the same.
> When moving files, it helps if you can use the '-M' (or
> '--find-renames') option to git-format-patch. That will give much
> smaller output that's easier to review. And if you had to change
> anything in the move, it should also help highlight exactly what
> changed, instead of including the entire file "diff".
Thanks a lot for your suggestion. I'm quite new with patch submit.
So please feel free to point out my missing/mistake. Thanks in advance.
> P.S. Incidentally, this should also work around your issues with the
> copyright symbol. But then, I suspect that some people have used these
> sorts of non-ASCII characters just to fish out issues with mail
> clients/MTAs like yours :)