Re: [PATCH RESEND] rtsx_usb_ms: Use msleep_interruptible() in polling loop
From: Lee Jones
Date: Mon Sep 28 2015 - 06:34:53 EST
The subsystem is missing from the subject line.
On Mon, 28 Sep 2015, Ben Hutchings wrote:
> rtsx_usb_ms creates a task that mostly sleeps, but tasks in
> uninterruptible sleep still contribute to the load average (for
> bug-compatibility with Unix). A load average of ~1 on a system that
> should be idle is somewhat alarming.
> Change the sleep to be interruptible, but still ignore signals.
> A better fix might be to replace this loop with a delayed work item.
> References: https://bugs.debian.org/765717
> Signed-off-by: Ben Hutchings <ben@xxxxxxxxxxxxxxx>
How was this patch made? Where's the diff etc?
Why was this patch sent to me?
> --- a/drivers/memstick/host/rtsx_usb_ms.c
> +++ b/drivers/memstick/host/rtsx_usb_ms.c
> @@ -706,7 +706,8 @@ poll_again:
> if (host->eject)
> - msleep(1000);
> + if (msleep_interruptible(1000))
> + flush_signals(current);
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/