Re: [PATCH RESEND] rtsx_usb_ms: Use msleep_interruptible() in polling loop
From: Ben Hutchings
Date: Mon Sep 28 2015 - 07:10:20 EST
On Mon, 2015-09-28 at 11:34 +0100, Lee Jones wrote:
> The subsystem is missing from the subject line.
> On Mon, 28 Sep 2015, Ben Hutchings wrote:
> > rtsx_usb_ms creates a task that mostly sleeps, but tasks in
> > uninterruptible sleep still contribute to the load average (for
> > bug-compatibility with Unix). A load average of ~1 on a system
> > that
> > should be idle is somewhat alarming.
> > Change the sleep to be interruptible, but still ignore signals.
> > A better fix might be to replace this loop with a delayed work
> > item.
> > References: https://bugs.debian.org/765717
> > Signed-off-by: Ben Hutchings <ben@xxxxxxxxxxxxxxx>
> How was this patch made? Where's the diff etc?
> Why was this patch sent to me?
I think I must have added you previously as MFD maintainer, but as this
doesn't touch rtsx_pcr or rtsx_usb it's not really in your area. Sorry
to bother you.
> > ---
> > --- a/drivers/memstick/host/rtsx_usb_ms.c
> > +++ b/drivers/memstick/host/rtsx_usb_ms.c
> > @@ -706,7 +706,8 @@ poll_again:
> > if (host->eject)
> > break;
> > - msleep(1000);
> > + if (msleep_interruptible(1000))
> > + flush_signals(current);
> > }
> > complete(&host->detect_ms_exit);
All extremists should be taken out and shot.
Description: This is a digitally signed message part