Re: [PATCH v2 1/1] net sysfs: Print link speed as signed integer

From: Jeremy Harris
Date: Tue Sep 29 2015 - 11:14:10 EST

On 28/09/15 14:05, Alexander Stein wrote:
Otherwise 4294967295 (MBit/s) (-1) will be printed when there is no link.
Documentation/ABI/testing/sysfs-class-net does not state if this shall be
signed or unsigned.
Also remove the now unused variable fmt_udec.
- ret = sprintf(buf, fmt_udec, ethtool_cmd_speed(&cmd));
+ ret = sprintf(buf, fmt_dec, ethtool_cmd_speed(&cmd));

If we print anything numeric, why is zero not appropriate
(which would still be unsigned)?
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at