Re: [PATCH] kselftest: replace $(RM) with rm -f command
From: Kees Cook
Date: Tue Sep 29 2015 - 13:45:46 EST
On Tue, Sep 29, 2015 at 2:57 AM, Michael Ellerman <mpe@xxxxxxxxxxxxxx> wrote:
> On Mon, 2015-09-28 at 03:16 +0000, Mathieu Desnoyers wrote:
>> ----- On Sep 27, 2015, at 10:10 PM, Wang Long long.wanglong@xxxxxxxxxx wrote:
>> > Some test's Makefile using "$(RM)" while the other's
>> > using "rm -f". It is better to use one of them in all
>> > tests.
>> I agree that this disparity appears to be unwanted. We
>> should settle on one or the other.
>> > "rm -f" is better, because it is less magic, and everyone
>> > konws what is does.
>> "$(RM)" is clearly defined as a Makefile implicit variable
>> which defaults to "rm -f".
>> Ref. https://www.gnu.org/software/make/manual/html_node/Implicit-Variables.html
> Sure, but you had to look it up didn't you :) - I did.
>> Leaving it as a variable is more flexible because then the
>> default behavior can be overridden if need be, which is
>> not the case of a hardcoded "rm -f".
> But I don't think anyone actually wants to do that. Do they?
> Anyway I don't really care either way, so I'm happy for you to do a patch that
> uses $(RM). Or maybe Wang Long will be happy to respin his patch to use $(RM).
Yes, please. $(RM) is preferred, as that is the existing standard and
gives us flexibility.
Chrome OS Security
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/