Re: [PATCH v3 4/5] regulators: tps65912: Add regulator driver for the TPS65912 PMIC
From: Mark Brown
Date: Tue Sep 29 2015 - 14:38:52 EST
On Tue, Sep 29, 2015 at 01:08:50PM -0500, Andrew F. Davis wrote:
> On 09/29/2015 10:13 AM, Mark Brown wrote:
> >>sure that will save me anything as my probe function is called with a DT
> >>match already, so no searching is needed.
> >You've not understood what that change is replacing, the code I'm
> >quoting above is exactly that code. Check out some of the existing
> >drivers using this API.
> Looking at other drivers that use this API they all call regulator_register
> in a loop in their probe, once for each possible regulator, in this case
> letting the API do the DT node search makes sense. My probe on the other-hand
> is only called when we already have a DT match, therefor searching is not
> necessary and all I have to do is call of_get_regulator_init_data myself on
> the already found DT node. No need to add node names to my regulator_desc
> and make the API re-search for the node.
Oh, ick. The binding has a compatible string in the individual
regulator bindings which is broken unless there really are lots of
variants being configured via DT (which is just not the case here).
It's not only more typing in the DT, it also means that we can't read
back the configuration of the device unless the user goes and creates a
DT which explicitly lists each regulator on the device which is
unhelpful. We should be able to read back the configurations of all the
regulators by simply listing the device in DT.
The fact that this is different to the bindings for other regulator
drivers and requires more code ought to have been a big warning sign
Description: Digital signature