Re: [PATCH 1/2] drivers: staging: wilc1000: Replace message queue with standard Linux lists
From: Chandra Gorentla
Date: Wed Sep 30 2015 - 08:30:10 EST
On Tue, Sep 29, 2015 at 02:44:02AM +0200, Greg KH wrote:
> On Mon, Sep 28, 2015 at 11:43:55PM +0530, Chandra S Gorentla wrote:
> > - The message queue is replaced with standard Linux linked list
> > - kmem_cache is used for list members
The list entires are of fixed type and repeatedly allocated and deallocated
> > - A check for return value of receive method is added
> > - GFP_ATOMIC is changed to GFP_KERNEL
> Why? Are you sure that is safe?
The allocations are moved out of 'spin_lock_irqsave' and
'spin_unlock_irqrestore'. Hence they are safe.
> > - A few other related minor changes
> Be specific please.
OK. I will try to send seperate patches.
> greg k-h
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/