Re: [PATCH v2] mtd: mtdram: fix build error

From: Brian Norris
Date: Wed Sep 30 2015 - 11:51:21 EST


On Wed, Sep 30, 2015 at 06:59:26PM +0530, Sudip Mukherjee wrote:
> i386 allmodconfig fails with:
> ERROR: "__umoddi3" [drivers/mtd/devices/mtdram.ko] undefined!
> ERROR: "__moddi3" [drivers/mtd/devices/mtdram.ko] undefined!
>
> arm allmodconfig fails with:
> ERROR: "__aeabi_uldivmod" [drivers/mtd/devices/mtdram.ko] undefined!
> ERROR: "__aeabi_ldivmod" [drivers/mtd/devices/mtdram.ko] undefined!
>
> mips allmodconfig fails with:
> ERROR: "__umoddi3" [drivers/mtd/devices/mtdram.ko] undefined!
> ERROR: "__moddi3" [drivers/mtd/devices/mtdram.ko] undefined!
>
> The modulus operation is not being supported by these compilers. Use
> do_div() instead which returns the remainder.
>
> Fixes: 7827e3acad2d ("mtd: mtdram: check offs and len in mtdram->erase")
> Signed-off-by: Sudip Mukherjee <sudip@xxxxxxxxxxxxxxx>
> ---
>
> v1 showed build warning with cris and xtensa. I have checked v2 with
> arm, cris and xtensa.

I already reverted the bad patch, so this doesn't apply any more...

If you want to send a squashed patch that redoes this properly, I can
take it.

Brian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/