Re: [PATCH v3 4/5] regulators: tps65912: Add regulator driver for the TPS65912 PMIC
From: Mark Brown
Date: Wed Sep 30 2015 - 13:29:16 EST
On Tue, Sep 29, 2015 at 01:58:41PM -0500, Andrew F. Davis wrote:
> On 09/29/2015 01:38 PM, Mark Brown wrote:
> >Oh, ick. The binding has a compatible string in the individual
> >regulator bindings which is broken unless there really are lots of
> >variants being configured via DT (which is just not the case here).
> >It's not only more typing in the DT,
> I don't see this, the alternative is matching to this "regulator-compatible",
> why not just use the existing compatible.
No, you don't need to use regulator-compatible - that's deprecated.
Just use the node names.
> >it also means that we can't read
> >back the configuration of the device unless the user goes and creates a
> >DT which explicitly lists each regulator on the device which is
> >unhelpful. We should be able to read back the configurations of all the
> >regulators by simply listing the device in DT.
> Could you expand this? I'm not sure I understand why we still cant do this
> using this new way.
I'm not sure what there is to add... if the regulator is only
instantiated when it features in the device tree then obviously it must
be included in the device to be instantiated.
> Bindings should have compatible strings when they describe hardware like this,
> we can then do stuff like put the LDO and DCDC drivers in separate modules for
> instance, letting DT only load what we need. There are other benefits like
> not having to search our own DT binding for data, and we only get probed for
> devices in the DT.
Only getting probed for device is in DT is exactly the problem here, and
nothing prevents us having separate modules for things without
enumerating everything in DT.
> This also eliminates the need for MFD_CORE, we just call
> of_platform_populate on ourself and DT helpers do the rest. Why hard code
> mfd_cell's and do matching when DT does the same thing.
Putting everything in DT means more work for people integrating the
device and means that we have to have a full and complete understanding
of the device at the time we write the DT, including decions about how
we split the functionality of the device between subsystems.
> >The fact that this is different to the bindings for other regulator
> >drivers and requires more code ought to have been a big warning sign
> >here :(
> The binding is the same as the new tps65218 driver, different isn't always
> a warning sign. And what do you mean "requires more code"? This regulator
> driver is smaller than almost any other. DT takes care of everything for
> us relating to hardware instantiation like it should.
That's not a new driver, it's from more than a year ago (before or about
the same time the helpers got added IIRC).
Description: Digital signature