Re: [PATCH] cris: kgdb: use native hex2bin

From: Jesper Nilsson
Date: Wed Sep 30 2015 - 14:08:45 EST


On Wed, Sep 30, 2015 at 06:37:51PM +0300, Andy Shevchenko wrote:
> On Wed, 2015-09-30 at 17:22 +0200, Jesper Nilsson wrote:
> > On Wed, Sep 30, 2015 at 04:46:53PM +0200, Andy Shevchenko wrote:
> > > On Tue, 2013-06-04 at 11:51 +0300, Andy Shevchenko wrote:
> > > > There are kernel native helpers to convert hex ascii to the
> > > > binary
> > > > format:
> > > > hex_to_bin() and hex2bin(). Thus, no need to reimplement them
> > > > customly.
> > > >
> > >
> > > No one is interested in this?
> >
> > Hm, dunno why, but obviously I've missed these patches,
> > and I can't find them on my main mailaccount either.
> >
> > Anyways, I found them on a secondary account, and have
> > added them to the CRIS linux-next tree.
>
> Just noticed that it was along time ago and currently it might produce
> compile warnings or errors since now hex2bin is prefixed by
> __must_check.
>
> Would you like me to send v2?

Unless you've tweaked them more since you sent them,
it shouldn't be necessary, the patches applied cleanly.
Those (most) files in CRIS are not touched very often... :-)

> Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

/^JN - Jesper Nilsson
--
Jesper Nilsson -- jesper_at_jni.nu
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/