Re: [RESEND PATCH v3 1/1] Add Corsair Vengeance K90 driver

From: Jiri Kosina
Date: Wed Sep 30 2015 - 15:33:41 EST

On Wed, 30 Sep 2015, Clément Vuchener wrote:

> This patch implements a HID driver for the Corsair Vengeance K90 keyboard.
> It fixes the behaviour of the keys using incorrect HID usage codes and
> exposes the macro playback mode and current profile to the user space
> through sysfs attributes. It also adds two LED class devices controlling
> the "record" LED and the backlight.
> Signed-off-by: Clément Vuchener <clement.vuchener@xxxxxxxxx>
[ ... snip ... ]
> +struct k90_led {
> + struct led_classdev cdev;
> + int brightness;
> + struct work_struct work;
> + int removed;

This could be made bool.

Also the patch subject doesn't really follow the usual format we're using
in hid.git.

Otherwise I like the code, thanks a lot for working on the driver. I have
fixed the nits above and it's now queued in hid.git#for-4.4/corsair.

Jiri Kosina

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at