Re: [PATCH v3 4/5] regulators: tps65912: Add regulator driver for the TPS65912 PMIC
From: Mark Brown
Date: Wed Sep 30 2015 - 18:20:54 EST
On Wed, Sep 30, 2015 at 03:29:30PM -0500, Andrew F. Davis wrote:
> On 09/30/2015 12:28 PM, Mark Brown wrote:
> >No, you don't need to use regulator-compatible - that's deprecated.
> >Just use the node names.
> Are we sure matching on node names is a good idea? Most are just arbitrary
> names meant to be human readable and reference-able, giving them function
> may lead to confusion. This seems to be why we have "compatible", for specific
> identification of node function. But I'm new so maybe I'm wrong?
Yes, I'm sure. The regulators are just properties on the device, they
are not devices themselves.
> >I'm not sure what there is to add... if the regulator is only
> >instantiated when it features in the device tree then obviously it must
> >be included in the device to be instantiated.
> This is already the case then, missing regulator nodes in old drivers will not
> get instantiated ether. And old drivers don't always store any more info about
> available regulators than mine does.
No, well implemented older drivers will still unconditionally register
> >Only getting probed for device is in DT is exactly the problem here, and
> >nothing prevents us having separate modules for things without
> >enumerating everything in DT.
> Sure, but then we have to do some fiddling with MFD_CORE to do that work,
> why not remove the dependency and let DT do that for DT only drivers?
For the reasons I've outlined repeatedly.
> >Putting everything in DT means more work for people integrating the
> >device and means that we have to have a full and complete understanding
> >of the device at the time we write the DT, including decions about how
> >we split the functionality of the device between subsystems.
> We are not adding anything extra to the DT node, we just use the "compatible"
> string to identify and match the node vs. "regulator-name", or the nodes name,
> or whatever else has been used. The node is then just filled with the standard
> optional properties just like every other driver's node.
No, you are missing the point. The point is that only regulators
explicitly listed in the DT will be instantiated.
> Newer than a lot, I chose to base my driver off of that not just because
> it is a similar TI part, but because it was the cleanest, simplest looking
> one IMHO. The helpers would require more code (you need to know how many
> regulators you have and call the helpers in a loop).
You're talking about a trivial loop that takes perhaps a couple of lines
to open and close the for loop and another line to declare an iterator
Look, please stop arguing about this. There appears to be nothing
special about this device that makes it different to other devices.
> I have another PMIC I'm about to push a driver for when this gets figured out
> that does the same thing, and it's more important I think to do it this way for
> this new part. Some of the new regulators are designed without a dedicated
> SOC or board to power in mind, so they will have a whole bunch for different
> regulator types on one chip and it will be up to the designer to pick which ones
> to turn on and use. With this DT approach you can just list the ones you want,
> and we may even be able to split different types into different modules, then
> we can use the same regulator driver in different spins of the PMIC with more
> or less of that type of regulator, we just add that same node under a different
> parent PMIC driver.
This sounds exactly the same as the majority of PMIC drivers, there is
nothing remarkable here.
> I could use the helper with this style and save a couple lines of code if we
> could make regulator_of_get_init_data to also match on "compatible", it
> currently only matches on "regulator-compatible" or the node name. I could make
> this addition and send the patch if you would like to see what I have in mind.
No, this would be broken - devices are instantiated via the driver
Description: Digital signature