Re: [PATCH] tracing: use kstrdup_const instead of private implementation

From: Steven Rostedt
Date: Thu Oct 01 2015 - 09:04:27 EST


On Wed, 30 Sep 2015 21:43:00 +0200
Rasmus Villemoes <linux@xxxxxxxxxxxxxxxxxx> wrote:

> On Wed, Sep 09 2015, Rasmus Villemoes <linux@xxxxxxxxxxxxxxxxxx> wrote:
>
> ping

Thanks for the reminder. I'll take a look at your patches today.

-- Steve

>
> > The kernel now has kstrdup_const/kfree_const for reusing .rodata
> > (typically string literals) when possible; there's no reason to
> > duplicate that logic in the tracing system. Moreover, as the comment
> > above core_kernel_data states, it may not always return true for
> > .rodata - that is for example the case on x86_64, where we thus end up
> > kstrdup'ing all the passed-in strings.
> >
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/