Re: [lkp] [PATCH v4 3/5] mfd: tps65912: Add driver for the TPS65912 PMIC

From: Mark Brown
Date: Fri Oct 02 2015 - 09:48:14 EST


On Fri, Oct 02, 2015 at 09:32:12PM +0800, Fengguang Wu wrote:
> On Fri, Oct 02, 2015 at 10:58:59AM +0100, Mark Brown wrote:

> > > All error/warnings (new ones prefixed by >>):

> > It would be good if somewhere early on in these mails the report said if
> > the build failed - that's key information about how urgent issues are
> > and it's not always clear if things are errors or warnings.

> When the robot say "All error/warnings" it has build failure (and
> possibly warnings). If there are only build warnings it'll say

> All warnings (new ones prefixed by >>):

Ah, I see - it's more clear in the warnings only case, it's less obvious
in the errors case that this message would be different if there were
only warnings.

> Would you like making that line more clear, or show the info
> earlier in the email body or even email title? For example,
> the first line could be changed to

> [auto build test ERROR on v4.3-rc3 -- if it's inappropriate base, please ignore]
> [auto build test WARNING on v4.3-rc3 -- if it's inappropriate base, please ignore]

> depending on whether it has build failure or just warnings.

That would be excellent, yes.

Attachment: signature.asc
Description: Digital signature