Re: [PATCH v4 17/26] ARM: pxa: magician: Fix wrongly enabled USB host ports

From: Philipp Zabel
Date: Sat Oct 03 2015 - 08:45:34 EST


Am Montag, den 28.09.2015, 23:38 +0200 schrieb Petr Cvek:
> USB host ports on the HTC Magician are wrongly enabled. Port 1 is for
> bluetooth and port 2 is for OTG (mux in the charger connector).
>
> Signed-off-by: Petr Cvek <petr.cvek@xxxxxx>
> ---
> arch/arm/mach-pxa/magician.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-pxa/magician.c b/arch/arm/mach
> -pxa/magician.c
> index 8e8b122..af8133a 100644
> --- a/arch/arm/mach-pxa/magician.c
> +++ b/arch/arm/mach-pxa/magician.c
> @@ -780,8 +780,10 @@ static struct pxamci_platform_data
> magician_mci_info = {
>
> static struct pxaohci_platform_data magician_ohci_info = {
> .port_mode = PMM_PERPORT_MODE,
> - .flags = ENABLE_PORT1 | ENABLE_PORT3 |
> POWER_CONTROL_LOW,
> + /* port1: CSR Bluetooth, port2: OTG with UDC */
> + .flags = ENABLE_PORT1 | ENABLE_PORT2 |
> POWER_CONTROL_LOW,
> .power_budget = 0,
> + .power_on_delay = 100,
> };

I have only ever tested the CSR bluetooth chip, so this could be
correct, or again something that is different between the magician
variants. I don't know.

regards
Philipp
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/