Re: [PATCH 3/3] Staging: rtl8192u: remove ieee80211_ccmp_null()

[Greg KH]

On Sat, Oct 03, 2015 at 01:09:56PM -0800, mike dupuis wrote:
> This is a patch to remove the function ieee80211_ccmp_null().
> This function does nothing and can therefore be safely removed.
> 
> Signed-off-by: Mike Dupuis <mike.dupuis.0@xxxxxxxxx>
> ---
>  drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
> index 61edd57..af22ee5 100644
> --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
> +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
> @@ -175,9 +175,6 @@ struct net_device *alloc_ieee80211(int sizeof_priv)
>  	  ieee->last_packet_time[i] = 0;
>  	}
>  
> -/* These function were added to load crypte module autoly */
> -	ieee80211_ccmp_null();
> -

You didn't remove the function, only the call to it.

And I think you just broke the "autoload" logic that these "call a null
function" function calls were trying to solve, which isn't good at all.
Have you verified that everything correctly auto-loads when the device
is plugged into the system?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/