Re: [RFC/PATCH 09/11] clocksource: add TI 32.768 Hz counter driver

From: Tony Lindgren
Date: Mon Oct 05 2015 - 07:03:47 EST


* Tony Lindgren <tony@xxxxxxxxxxx> [151005 03:56]:
> * Daniel Lezcano <daniel.lezcano@xxxxxxxxxx> [151001 15:04]:
> > >+ clocks_calc_mult_shift(&persistent_mult, &persistent_shift,
> > >+ 32768, NSEC_PER_SEC, 120000);
> > >+
> > >+ ret = clocksource_mmio_init(sync32k_cnt_reg, "32k_counter", 32768,
> > >+ 250, 32, clocksource_mmio_readl_up);
> > >+ if (ret) {
> > >+ pr_err("32k_counter: can't register clocksource\n");
> > >+ return;
> > >+ }
> > >+
> > >+ sched_clock_register(omap_32k_read_sched_clock, 32, 32768);
> > >+ register_persistent_clock(NULL, omap_read_persistent_clock64);
> >
> > I will let John Stultz to have a look at this part because I have doubt
> > regarding the usage of the persistent clock.
>
> The persistent clock we want to keep for deeper idle states..
> Especially when we start changing clocksource for the duration of
> deeper idle states. I'll post some updated patches on that when I
> get a chance.

But sounds like we can just have read_persistent_clock() check
for the CLOCK_SOURCE_SUSPEND_NONSTOP like I pointed in the other
patch in this series.

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/