Re: [PATCH v2 09/36] x86/asm: Re-add manual CFI infrastructure

From: Ingo Molnar
Date: Thu Oct 08 2015 - 10:15:04 EST



* Borislav Petkov <bp@xxxxxxxxx> wrote:

> On Tue, Oct 06, 2015 at 11:21:41AM -0700, Andy Lutomirski wrote:
>
> > OK, I'll strip out the push, movq, etc stuff for v3. I'll leave all of the
> > CFI_XYZ macros, even the unused one, because that's only a couple of lines of
> > code and they all have very simple and obvious meanings (or as simple as the
> > underlying directives, anyway).
>
> If they're going to be used by the vDSO only, maybe they all should go into a
> header which is private to the vDSO only so that people don't get any ideas and
> the gunk starts spreading again...

Yeah. So for the vDSO code itself it's an obvious step forward: replacing black
magic hexa encodings with symbolic directives.

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/