Re: [PATCH v3] mm,thp: reduce ifdef'ery for THP in generic code

From: Vineet Gupta
Date: Fri Oct 09 2015 - 09:41:31 EST


On Friday 09 October 2015 07:04 PM, Kirill A. Shutemov wrote:

On Fri, Oct 09, 2015 at 06:34:10PM +0530, Vineet Gupta wrote:


> On Friday 09 October 2015 05:13 PM, Vineet Gupta wrote:


> > - pgtable-generic.c: Fold individual #ifdef for each helper into a top
> > level #ifdef. Makes code more readable
> >
> > - Converted the stub helpers for !THP to BUILD_BUG() vs. runtime BUG()
> >
> > Signed-off-by: Vineet Gupta <vgupta@xxxxxxxxxxxx><mailto:vgupta@xxxxxxxxxxxx>


>
> Sorry for sounding pushy - an Ack here will unblock me from dumping boat load of
> patches into linux-next via my tree !


I hope you've tested it with different .configs...

Acked-by: Kirill A. Shutemov <kirill.shutemov@xxxxxxxxxxxxxxx><mailto:kirill.shutemov@xxxxxxxxxxxxxxx>

Atleast 2 configs with CONFIG_TRANSPARENT_HUGEPAGE on and off - for ARC !

I can test some more if u point me to.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/