Re: [PATCH 1/1] x86/intel-mid: modify a code to suppress a warning

From: Andy Shevchenko
Date: Fri Oct 09 2015 - 11:10:44 EST


On Fri, 2015-10-09 at 16:01 +0200, Thomas Gleixner wrote:
> On Fri, 9 Oct 2015, Andy Shevchenko wrote:
>
> Please stop to write subject lines like this.
>
> x86/intel-mid: modify a code to suppress a warning
>
> This is completely useless as it does not tell what kind of warning
> (compile time, runtime). Further it says that the patch modifies
> code, which is completely pointless, right?
>
> What's wrong with:
>
> x86/intel-mid: Make intel_mid_ops static
>
> I end up rewriting your subject lines and changelogs on a regular
> base. You really should have noticed that by now and started to spend
> a little bit more effort yourself.

Thank you.

>
> Thanks,
>
> tglx
>
>

--
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/