Re: [PATCH 05/10] clk: iproc: Add PLL base write function

From: Jon Mason
Date: Fri Oct 09 2015 - 14:02:04 EST


On Fri, Oct 09, 2015 at 12:03:57AM -0700, Stephen Boyd wrote:
> On 10/02, Jon Mason wrote:
> > diff --git a/drivers/clk/bcm/clk-iproc-pll.c b/drivers/clk/bcm/clk-iproc-pll.c
> > index e029ab3..a4602aa 100644
> > --- a/drivers/clk/bcm/clk-iproc-pll.c
> > +++ b/drivers/clk/bcm/clk-iproc-pll.c
> > @@ -137,6 +137,18 @@ static int pll_wait_for_lock(struct iproc_pll *pll)
> > return -EIO;
> > }
> >
> > +static void iproc_pll_write(struct iproc_pll *pll, void __iomem *base,
>
> Seems that pll could be const too?

Yes, and offset can be const too. I'll make these changes and
resubmit.

Thanks,
Jon

>
> > + u32 offset, u32 val)
> > +{
> > + const struct iproc_pll_ctrl *ctrl = pll->ctrl;
> > +
>
> --
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
> a Linux Foundation Collaborative Project
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/