Re: [PATCH 14/14] cgroup: add cgroup_subsys->free() method and use it to fix pids controller

From: Aleksa Sarai
Date: Mon Oct 12 2015 - 06:29:20 EST


> pids controller is completely broken in that it uncharges when a task
> exits allowing zombies to escape resource control. With the recent
> updates, cgroup core now maintains cgroup association till task free
> and pids controller can be fixed by uncharging on free instead of
> exit.

Looks good to me. Out of interest, is there any reason why we still
have ->exit(), given the zombie process edge case? Surely the zombie
process edge case would cause issues with kmemcg and similar
controllers, if they use ->exit() and not ->free()?

--
Aleksa Sarai (cyphar)
www.cyphar.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/