Re: [PATCH 2/2] dt-bindings: Add new boards to bcm4708 DT bindings

From: Florian Fainelli
Date: Tue Oct 13 2015 - 18:38:23 EST


On 13/10/15 14:40, Jon Mason wrote:
> On Sat, Oct 10, 2015 at 04:42:04PM +0200, Hauke Mehrtens wrote:
>> On 10/03/2015 12:22 AM, Jon Mason wrote:
>>> Add the 4708, 4709, and 953012k SVKs to the the documentation for the
>>> Broadcom Northstar device tree bindings.
>>>
>>> Signed-off-by: Jon Mason <jonmason@xxxxxxxxxxxx>
>>> ---
>>> Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.txt | 7 +++++++
>>> 1 file changed, 7 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.txt b/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.txt
>>> index 6b0f49f..bdf4c06 100644
>>> --- a/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.txt
>>> +++ b/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.txt
>>
>> What should be documented in this file? This is more a question to the
>> guys more familiar with arm in Linux. Currently the Linux kernel only
>> supports brcm,bcm4708 and all goes back to that one.
>
> I was under the impression that all boards should be added to these
> files. We have been doing so for Cygnus and NSP.

Tracking exactly which boards are supported by the brcm,bcm4708
compatible string might be tedious, I tend to agree with just listing
the supported SoCs, and leaving the specific board compatibles to the
individual DTS files instead.

>
> Thanks,
> Jon
>
>>
>>> @@ -5,4 +5,11 @@ Boards with the BCM4708 SoC shall have the following properties:
>>>
>>> Required root node property:
>>>
>>> +bcm94709
>>> compatible = "brcm,bcm4708";
>>> +
>>> +bcm94709
>>> +compatible = "brcm,bcm4709", "brcm,bcm4708";
>>> +
>>> +bcm953012k
>>> +compatible = "brcm,bcm5301k", "brcm,bcm4708";
>>>
>>


--
Florian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/