Re: [PATCH 0/5] x86/setup/crash: Cleanup some code

From: Joerg Roedel
Date: Thu Oct 15 2015 - 11:34:00 EST


On Thu, Oct 15, 2015 at 10:20:26AM +0200, Borislav Petkov wrote:
> this is ontop of Baoquan's fix from yesterday:
> https://lkml.kernel.org/r/20151014104338.GA8235@xxxxxxx
>
> Looking at the crashkernel reservation code made a couple of style
> problems wink at me so this short cleanup should address them. Please
> take a look and complain if something's wrong.
>
> Thanks.
>
> Borislav Petkov (5):
> x86/setup: Cleanup crashkernel reservation functions
> x86/setup/crash: Remove alignment variable
> x86/setup/crash: Cleanup some more
> x86/setup/crash: Check memblock_reserve() retval
> kexec/crash: Say which char is the unrecognized
>
> arch/x86/kernel/setup.c | 81 +++++++++++++++++++++++++------------------------
> kernel/kexec_core.c | 6 ++--
> 2 files changed, 45 insertions(+), 42 deletions(-)

Looks good to me.

Reviewed-by: Joerg Roedel <jroedel@xxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/