Re: [PATCH 01/16] PM / OPP: Add 'supply-names' binding

From: Stephen Boyd
Date: Fri Oct 16 2015 - 15:17:07 EST


On 10/16, Viresh Kumar wrote:
> On 15-10-15, 17:22, Stephen Boyd wrote:
> > I'm lost why we need this property at all. What happened to using
> >
> > opp-microvolt-0 = <1 2 3>;
> > opp-microvolt-1 = <1>;
> > opp-microvolt-2 = <3 4 5>;
> > etc.
>
> Perhaps you are confusing this with the bindings we came up for
> picking right voltage levels based on the cuts/version of the hardware
> we are running on. The problem that Lee Jones mentioned and that can
> be used in your case as well.

Isn't that what this patch series is for?

>
> > That seems to avoid any problem with 3 vs. 1 element properties
> > combined into one large array.
>
> That's not the problem I was trying to solve here.

What problem are you trying to solve then?

>
> > Having supply-names seems too
> > brittle and would tie us to a particular OPP user's decision to
> > call supplies by some name.
>
> No. The name has to match the <name>-supply property present in the
> device's node, that's why we need this property :)

Why does it need to match? Sorry I'm totally lost now.

--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/