Re: [PATCH v4 6/8] drivers: soc: add support for exynos SROM driver

From: Pankaj Dubey
Date: Tue Oct 20 2015 - 04:21:32 EST


On Tuesday 20 October 2015 12:18 PM, Krzysztof Kozlowski wrote:
On 20.10.2015 15:33, Pavel Fedin wrote:
Hello!

AFAIR Fedin was talking about missing functionality, not about adding
the contribution by himself. So he might add it or he might not. I did
not receive any commitments from him.

I am waiting for the driver to be integrated, because i see it's constantly redesigned. Then i'll post my patches.

That means you will extend the driver? Great! So from my point of view
it is fine.

Dear Pankaj,

With the fix of unneeded NULL assignments:

Reviewed-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx>


Thanks. Will update v5 soon with suggested modification.

Thanks,
Pankaj Dubey

By the way, they
will be useful only if pin controller driver for 5410 is accepted upstream, several authors have done it but i still didn't see it
in upstream.
Pin controller is needed in order to configure multi-functional pins correctly.

Are there any obstacles for upstreaming it?

Best regards,
Krzysztof


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/